Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and packaging fixes #5733

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

clebergnu
Copy link
Contributor

A small collection of fixes and cleanups related to build and packaging.

Aexpect was last used in a selftests before a640bf4.

Signed-off-by: Cleber Rosa <[email protected]>
In 847d536, elementpath and xmlschema were added to the build
requirements with the reasoning that coverage was expanded (the tests
that relied on "them" would be enable at build time).  But, in fact,
only xmlschema was being used at the time, and that remains today.

Let's remove elementpath for a cleaner set of build requirements.

Signed-off-by: Cleber Rosa <[email protected]>
Commit 033e522 enabled the building of plugins' eggs as a pre-merge
check.  This adds the building and uploading of plugins' eggs as part
of the release process.

Signed-off-by: Cleber Rosa <[email protected]>
While building wheels, the following condition was caught:

* Getting build dependencies for wheel...
Traceback (most recent call last):
  File "/home/cleber/.local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
    main()
  File "/home/cleber/.local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 335, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/cleber/.local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
    return hook(config_settings)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/build-env-3g7hr9m7/lib/python3.11/site-packages/setuptools/build_meta.py", line 341, in get_requires_for_build_wheel
    return self._get_build_requires(config_settings, requirements=['wheel'])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/build-env-3g7hr9m7/lib/python3.11/site-packages/setuptools/build_meta.py", line 323, in _get_build_requires
    self.run_setup()
  File "/tmp/build-env-3g7hr9m7/lib/python3.11/site-packages/setuptools/build_meta.py", line 488, in run_setup
    self).run_setup(setup_script=setup_script)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/build-env-3g7hr9m7/lib/python3.11/site-packages/setuptools/build_meta.py", line 338, in run_setup
    exec(code, locals())
  File "<string>", line 43, in <module>
  File "<string>", line 34, in get_long_description
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/build-via-sdist-gu1zghmm/avocado-framework-plugin-varianter-pict-102.0/README.rst'

Which revealed a mistake introduced in 2e0591d that missed the
README.rst for the pict plugin.

Signed-off-by: Cleber Rosa <[email protected]>
@clebergnu clebergnu self-assigned this Jul 18, 2023
@clebergnu
Copy link
Contributor Author

@richtja FYI, the "Announcement" action is misbehaving:

https://github.com/avocado-framework/avocado/actions/runs/5592743617/jobs/10225594602?pr=5733

I wasn't able to properly figure out what is going on.

@mr-avocado
Copy link

mr-avocado bot commented Jul 19, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

@richtja
Copy link
Contributor

richtja commented Jul 19, 2023

@richtja FYI, the "Announcement" action is misbehaving:

https://github.com/avocado-framework/avocado/actions/runs/5592743617/jobs/10225594602?pr=5733

I wasn't able to properly figure out what is going on.

Hi @clebergnu, thank you for letting me know, there was a problem with mr-avocado permissions. I fix that and now it should be fine.

@clebergnu clebergnu requested a review from richtja July 20, 2023 11:22
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@richtja richtja merged commit ef20b85 into avocado-framework:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants